Updating the documentation to make selection of elements clear. #148
+93
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in` works. Also provides guidance on how to use the `google-signin-aware` with custom signin UIs. Closes #143
| <google-signin theme="dark" width="iconOnly" client-id="..." scopes="https://www.googleapis.com/auth/drive"></google-signin> | ||
| #### Notes | ||
| #### Notes |
Contributor
There was a problem hiding this comment.
why the indentation? For the doc viewer, this is read as markdown, so 4-space indents will make this a code block.
Contributor
Author
There was a problem hiding this comment.
Doesn't it use the spacing of the opening comment as the base for all of the lines?
If that is not true then I'll have to change it back.
Contributor
There was a problem hiding this comment.
It's probably easier if we just make the docs a html comment like https://github.com/GoogleWebComponents/google-sheets/blob/master/google-sheets.html#L7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provides guidance on how to use the
google-signin-awarewith custom signin UIs.Closes #143